fix: Remove the need of explicit import for SplitByType macros
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollandDM
commented
Dec 5, 2024
| @@ -4,7 +4,6 @@ import com.raquo.airstream.UnitSpec | |||
| import com.raquo.airstream.eventbus.EventBus | |||
| import com.raquo.airstream.fixtures.{Effect, TestableOwner} | |||
| import com.raquo.airstream.state.Var | |||
| import com.raquo.airstream.split.SplitMatchOneMacros.* | |||
HollandDM
commented
Dec 5, 2024
| @@ -6,7 +6,6 @@ import com.raquo.airstream.eventbus.EventBus | |||
| import com.raquo.airstream.fixtures.{Effect, TestableOwner} | |||
| import com.raquo.airstream.ownership.{DynamicOwner, DynamicSubscription, ManualOwner, Subscription} | |||
| import com.raquo.airstream.split.DuplicateKeysConfig | |||
| import com.raquo.airstream.split.SplitMatchSeqMacros.* | |||
|
Awesome, thank you very much for all your work on this! I will release 17.2.0 with this feature soon. |
raquo
pushed a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for taking so long to fix this, I was busy these days.
Macro inlining functions (which has body of ${ ... } ) are required to be in the same scope (maybe same file is good enough, but I always put them in the same object). So I just create some
deglate*functions and call them inline.