Remove /Oy- option for MSVC in CMakeLists.txt and set HAS_MSVC_NO_OMI…

…T_FRAME_POINTER flag
ratioSolver · Dec 31, 2024 · 6fbb5a9 · 6fbb5a9
1 parent 2efc613
commit 6fbb5a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -63,7 +63,8 @@ if(BUILD_TESTING)
 endif()
 
 if(MSVC)
-    target_compile_options(oRatioLib PRIVATE /W4 /Oy-)
+    target_compile_options(oRatioLib PRIVATE /W4)
+    set(HAS_MSVC_NO_OMIT_FRAME_POINTER ON CACHE BOOL "MSVC has no -fomit-frame-pointer" FORCE)
 else()
     target_compile_options(oRatioLib PRIVATE -Wall -Wextra -Wpedantic -fsanitize=undefined)
     if (ENABLE_COVERAGE)

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -2,7 +2,7 @@ add_executable(core_tests test_core.cpp)
 add_dependencies(core_tests oRatioLib)
 target_link_libraries(core_tests PRIVATE oRatioLib)
 if(MSVC)
-    target_compile_options(core_tests PRIVATE /W4 /Oy-)
+    target_compile_options(core_tests PRIVATE /W4)
 else()
     target_compile_options(core_tests PRIVATE -Wall -Wextra -Wpedantic -fsanitize=undefined)
     target_link_options(core_tests PRIVATE -fsanitize=undefined)
@@ -19,7 +19,7 @@ add_dependencies(solver_tests oRatioLib)
 target_compile_definitions(solver_tests PRIVATE NUM_TESTS=1)
 target_link_libraries(solver_tests PRIVATE oRatioLib)
 if(MSVC)
-    target_compile_options(solver_tests PRIVATE /W4 /Oy-)
+    target_compile_options(solver_tests PRIVATE /W4)
 else()
     target_compile_options(solver_tests PRIVATE -Wall -Wextra -Wpedantic -fsanitize=undefined)
     target_link_options(solver_tests PRIVATE -fsanitize=undefined)