Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multi-component spectral indices. #243

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow for multi-component spectral indices. #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0ecacf
Allow for multi-component spectral indices.
JSKenyon Apr 5, 2023
17e1a56
Tidy up and add a TODO>
JSKenyon Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion quartical/data_handling/predict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ def parse_sky_models(sky_models):
logger.info(f"Setting the default reference frequency for "
f"{sky_model_name} to {fallback_freq0}.")

# Figure out the maximum number of spectral index components.
# TODO: Check whether the current approach is too brittle.
spectrums = [getattr(s, "spectrum", _empty_spectrum) for s in sources]
spis = [getattr(s, "spi", 0) for s in spectrums]

if any(map(lambda obj: isinstance(obj, list), spis)):
spi_components = max(len(s) for s in spis if isinstance(s, list))
else:
spi_components = 1

for source in sources:

tagged = any([source.getTag(tag) for tag in sky_model_tags])
Expand All @@ -77,12 +87,18 @@ def parse_sky_models(sky_models):
# will error out. However, if the first source has a reference
# frequency set, we will instead default to that.

# TODO: The following assumes that the spi is the same for all the
# stokes components - this may need to be more flexible.

if (fallback_freq0 is None) or (fallback_freq0 == 0):
ref_freq = 1e9 # Non-zero default.
spi = [[0]*4] # Flat spectrum.
else:
ref_freq = getattr(spectrum, "freq0", fallback_freq0)
spi = [[getattr(spectrum, "spi", 0)]*4]
spi = getattr(spectrum, "spi", 0)
spi = [spi] if not isinstance(spi, list) else spi
spi.extend([0]*(spi_components - len(spi)))
spi = [[comp]*4 for comp in spi]

if typecode == "gau":
emaj = source.shape.ex
Expand Down Expand Up @@ -434,6 +450,9 @@ def predict(data_xds_list, model_vis_recipe, ms_path, model_opts):
extras["beam_lm_extents"] = lm_ext
extras["beam_freq_map"] = freq_map

# TODO: This needs to be detected/configurable.
# extras["spi_base"] = "log10"

model_vis = defaultdict(list)

# Generate visibility expressions per model, per direction for each
Expand Down