Add missing coerce_literal calls. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may also be able to use prefer_literal in the overload decorator as I do here https://github.com/ratt-ru/pfb-imaging/blob/fac50dcbd7eff06e9b0dddf0865244c268ab94f1/pfb/utils/weighting.py#L220 |
I have been meaning to give that a try. Maybe now is the time. |
JSKenyon
added a commit
that referenced
this pull request
Nov 29, 2024
* Add experimental combined delay and tec solver. (#339) * Commit initial attempt at delay and tec solver. * Add poor test for delay and tec. * Add missing coerce_literal calls. (#341) * Make schema consistent with that required by cult-cargo. (#346) * Update depdendencies (#345) * Partiallu update dependencies/lock while waiting for dask-ms release. * Remove 3.9 from test matrix. * Bump dependency versions. * Fix bad python version specification. * Fix for reindex change. Update Poetry lock. * Remove 3.12 support for now due to difficulties in tigger-lsm. * Update lock. * Add support for Python3.12 (#348) * Add python3.12 support. * Update lock. * Further lock update. * Serparate versioning for astro-tigger-lsm when using python 3.12. * EXPERIMENTAL: Add a crosshand phase solver which expolits the zero Stokes V assumption. (#344) * Initial commit of null V WIP. * Seemingly working implementation of solver exploiting the null-v trick. * Add new term type to allowed gain types. * Add a parallactic angle gain type. * Add test for parallactic angle term. Fix minor bugs. * Remove unused imports. * Improve removal of coords/attts added by quartical during writes. * remove question marks when plotting (#347) * remove question marks when plotting (treated as wildcard by ls in radio-padre) * Replace question marks with N/A. --------- Co-authored-by: Jonathan Kenyon <[email protected]> * Mark test as xfail die to sign ambiguity. --------- Co-authored-by: Landman Bester <[email protected]> --------- Co-authored-by: Landman Bester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Numba break the robust reweighting code due to incorrect literal evaluations. This PR add the necessary fix.