Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feed flip term. #355

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add feed flip term. #355

merged 2 commits into from
Jan 16, 2025

Conversation

JSKenyon
Copy link
Collaborator

@JSKenyon JSKenyon commented Dec 5, 2024

Finally caving to @o-smirnov and @bennahugo's requests. This adds an explicit feed flip term. This can be included in your solver.terms by selecting type feed_flip. Note that if you require parallactic angle correction, you should use the newly added explicit parallactic_angle term and not the input_model.apply_p_jones and output.apply_p_jones_inv options. The current approach will up computational complexity - I will work on improving this but it will be a big job as I will need to refactor how the gains are collapsed within the chain. That will likely be a separate future PR.

Currently unanswered questions:

  • Are the weights also flipped?
  • Is simply including the flip in the chain sufficient to address the problem?

@JSKenyon JSKenyon marked this pull request as ready for review January 16, 2025 06:55
@JSKenyon JSKenyon merged commit 203a13b into v0.2.6-dev Jan 16, 2025
8 checks passed
@JSKenyon JSKenyon deleted the v0.2.6-feed-flip branch January 16, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant