Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to collapse the Jones chain inside the solver #356

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

JSKenyon
Copy link
Collaborator

This PR adds functionality to optionally collapse the Jones chain prior to solution. This essentially means that the Jones chain is never more than three terms long from the perspective of the solver as any longer chain can always be reduced to at most three terms (and occasionally two). This should speed up calibration in cases where the chain becomes very long e.g. 1GC with polarisation, or where there is a direction-dependent term in the chain (which are expensive to apply on-the-fly). This functionality is enabled by default but can disabled using solver.collapse_chain=0.

@JSKenyon JSKenyon marked this pull request as ready for review January 16, 2025 12:45
@JSKenyon JSKenyon merged commit bbcff94 into v0.2.6-dev Jan 16, 2025
8 checks passed
@JSKenyon JSKenyon deleted the v0.2.6-collapse-chain branch January 16, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant