Add a scalar mode to diagonal parameterised Jones terms #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have decided to convert this to a draft for now as I should probably add tests for the scalar modes to the test suite. The scalar mode is non-invasive i.e. nothing which was working will have been broken by these changes, but there are a number of edges cases I should probably check work as expected e.g. does the generic code function correctly when there are fewer than four correlations? |
|
I have added a few tests but need to check how much they impact the testing time. The extra tests are not applied to all terms, but only to a representative subset. If they pass this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @o-smirnov in #357. This is a slightly more general offering; diagonal parameterised Jones terms now support a support a scalar mode where appropriate. This is enabled by setting
term.scalar=truewheretermis the name of any specified gain term.At present, the scalar mode is not supported for
diag_complexterms. This is because the solver is a little different for the diagonal complex case and the generic approach I have taken in this PR won't work.Edit: I have added support for scalar
diag_complexterms.