Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calver dependencies to use inequalities #307

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

sjperkins
Copy link
Member

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins sjperkins requested a review from JSKenyon January 25, 2024 09:35
@sjperkins
Copy link
Member Author

Test cases pass

@sjperkins
Copy link
Member Author

This PR changes dask-ms to install 2024 versions of calver'd software, mostly because they're specified using poetry's caret dependency scheme

This is because a ^2023.X.Y specifier results in a >= 2023.X.Y, < 2024.0.0 dependency range.

OTOH it might be possible to just use inequality requirements and keep the range lower.

But I think we'll need stricter requirements going forward due to task keys on the distributed scheduler changing from strings to tuples, as well as the upcoming integration of dask-expr into dask.

@JSKenyon
Copy link
Collaborator

JSKenyon commented Jan 29, 2024

One comment is that restricting the versioning to a specific year (calver) makes for weirdly quantised dependencies. I think that an inequality constraint is fine and means that things can change more smoothly. I do agree that there may be trouble on the horizon due to upstream churn.

Edit: My approach going forward is to mandate poetry installation for end-users.

@sjperkins
Copy link
Member Author

OK, I've relaxed the calver dependencies to inequality constraints. In combination with the python version, I think poetry will make sensible choices here.

@sjperkins sjperkins changed the title Update dask and xarray to 2024 calvers Update calver dependencies to use inequalities Jan 29, 2024
@sjperkins sjperkins force-pushed the update-calver-dependencies branch from 3f22340 to 47dfffe Compare January 29, 2024 11:17
@sjperkins sjperkins merged commit 52461dd into master Jan 29, 2024
13 checks passed
@sjperkins sjperkins deleted the update-calver-dependencies branch January 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants