-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calver dependencies to use inequalities #307
Conversation
Test cases pass |
This PR changes dask-ms to install 2024 versions of calver'd software, mostly because they're specified using poetry's caret dependency scheme This is because a OTOH it might be possible to just use inequality requirements and keep the range lower. But I think we'll need stricter requirements going forward due to task keys on the distributed scheduler changing from strings to tuples, as well as the upcoming integration of dask-expr into dask. |
One comment is that restricting the versioning to a specific year (calver) makes for weirdly quantised dependencies. I think that an inequality constraint is fine and means that things can change more smoothly. I do agree that there may be trouble on the horizon due to upstream churn. Edit: My approach going forward is to mandate poetry installation for end-users. |
OK, I've relaxed the calver dependencies to inequality constraints. In combination with the python version, I think poetry will make sensible choices here. |
3f22340
to
47dfffe
Compare
Tests added / passed
If the pep8 tests fail, the quickest way to correct
this is to run
autopep8
and thenflake8
andpycodestyle
to fix the remaining issues.Fully documented, including
HISTORY.rst
for all changesand one of the
docs/*-api.rst
files for new APITo build the docs locally: