Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge (yet): Delete unused assets, second try #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abrock
Copy link
Member

@abrock abrock commented Jan 11, 2022

Running a linkchecker on the first try #366 revealed that I deleted two assets which were actually used.

@abrock
Copy link
Member Author

abrock commented Jan 11, 2022

This version seems to have no missing assets (checked using "linkchecker" from Debian testing on the preview build). So the question is:

  1. Merge it to clean up the build / deployment but keep the files in the history, or
  2. Rewrite the history to actually reduce the repo size?

@tabascoeye
Copy link
Member

Reduce build time and deployment size would already be nice.
I'm not sure of the implications of rewriting git history.
Maybe others can comment?

@tabascoeye
Copy link
Member

@elsbrock @lutoma ?

@elsbrock
Copy link
Collaborator

Should be perfectly fine, but every fork/clone will potentially become invalid.

@tabascoeye
Copy link
Member

tabascoeye commented Jan 20, 2022

@abrock then let's rewrite history 🖖

@abrock
Copy link
Member Author

abrock commented Jan 20, 2022

Yes, but let's either merge or close all other open pull requests first.

@tabascoeye
Copy link
Member

all other pull requests closed/merged.

==> rebase or merge master back into this and go on with re-write, please @abrock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants