Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDoc-2535 Cannot project twice when making a query #1715

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

Danielle9897
Copy link
Member

@Danielle9897 Danielle9897 commented Nov 27, 2023

Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-2535/Cannot-project-twice-when-making-a-query

@maciejaszyk - Files to review:

Dynamic query projections:
Documentation/6.0/Raven.Documentation.Pages/client-api/session/querying/how-to-project-query-results.dotnet.markdown
Documentation/6.0/Samples/csharp/Raven.Documentation.Samples/ClientApi/Session/Querying/HowToProjectQueryResults.cs

Index query projections:
Documentation/6.0/Raven.Documentation.Pages/indexes/querying/projections.dotnet.markdown
Documentation/6.0/Samples/csharp/Raven.Documentation.Samples/Indexes/Querying/Projections.cs

Note:

  1. *.js and *.java files were only "copied over" to the 6.0 directory so they are visible as well - so no need to review them for now
  2. Node.js fixes will be applied in issue:
    https://issues.hibernatingrhinos.com/issue/RDoc-2245/Node.js-projectInto-in-Node.js-fix-article

@Danielle9897 Danielle9897 force-pushed the RDoc-2535-cannotProjectTwice branch from 1edc191 to a9b520d Compare November 27, 2023 20:16
Copy link
Member

@maciejaszyk maciejaszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

from "Orders"
select ShipTo, Lines[].ProductName as Products

// Using object literal syntax:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is worth mentioning that it's JavaScript.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
=> // Using JavaScript object literal syntax:

@ppekrol ppekrol merged commit b0e4414 into ravendb:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants