-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ukrop extension #16625
Add ukrop extension #16625
Conversation
- Ukrop Switcher v.1 - Initial commit
Congratulations on your new Raycast extension! 🚀 You can expect an initial review within five business days. Once the PR is approved and merged, the extension will be available on our Store. |
Thanks for your PR @yarul0 🔥 I'm not sure it makes sense to branch out here. Wouldn't it be better to have one unified extension that offers multiple languages as the only difference? @red-avtovo what do you think? |
Thanks @pernielsentikaer for moderation. I do agree, but the latest keyboard switch should somehow know the exact system name of the layout to switch to. I only recently switched to the new implementation and still discover what would be the best options here. @yarul0 sorry that my changes caused a disruption in your extension experience. I added all ru layouts only because I was thinking that the use cases are limited to these layouts only. Obviously, I was wrong, so I would graldly extend the Cyrillic layout list to all Ukranian keyboards and promote in the future to extend that list instead of forking the extension Additionally, please let me know @yarul0 if you would like to adjust the layout conversion map if that doesn't work in all cases |
Hello!
All good, no worries. I'm not going to do something else.
Thanks, for you time!
…On Tue, Feb 4, 2025 at 11:10 Aleksandr ***@***.***> wrote:
Thanks @pernielsentikaer <https://github.com/pernielsentikaer> for
moderation. I do agree, but the latest keyboard switch should somehow know
the exact system name of the layout to switch to. I only recently switched
to the new implementation and still discover what would be the best options
here.
@yarul0 <https://github.com/yarul0> sorry that my changes caused a
disruption in your extension experience. I added all ru layouts only
because I was thinking that the use cases are limited to these layouts
only. Obviously, I was wrong, so I would graldly extend the Cyrillic layout
list to all Ukranian keyboards and promote in the future to extend that
list instead of forking the extension
Additionally, please let me know @yarul0 <https://github.com/yarul0> if
you would like to adjust the layout conversion map if that doesn't work in
all cases
—
Reply to this email directly, view it on GitHub
<#16625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYVHX3F3ZDZAZTL3XLYZGN32OB7ZJAVCNFSM6AAAAABV4STIBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTGI4TKMBSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@yarul0 please take a look at my PR and let me know if anything is missing |
Looks good to me.
…On Tue, Feb 4, 2025 at 11:48 Aleksandr ***@***.***> wrote:
@yarul0 <https://github.com/yarul0> please take a look at my PR and let
me know if anything is missing
—
Reply to this email directly, view it on GitHub
<#16625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYVHX3DFC2AECPB7A4ZLB5D2OCEIDAVCNFSM6AAAAABV4STIBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTGM4DONBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder