Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ukrop extension #16625

Closed
wants to merge 1 commit into from
Closed

Add ukrop extension #16625

wants to merge 1 commit into from

Conversation

yarul0
Copy link

@yarul0 yarul0 commented Jan 26, 2025

Description

Screencast

Checklist

- Ukrop Switcher v.1
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jan 26, 2025
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@pernielsentikaer pernielsentikaer self-assigned this Feb 4, 2025
@pernielsentikaer
Copy link
Collaborator

Thanks for your PR @yarul0 🔥

I'm not sure it makes sense to branch out here. Wouldn't it be better to have one unified extension that offers multiple languages as the only difference?

@red-avtovo what do you think?

@red-avtovo
Copy link
Contributor

Thanks @pernielsentikaer for moderation. I do agree, but the latest keyboard switch should somehow know the exact system name of the layout to switch to. I only recently switched to the new implementation and still discover what would be the best options here.

@yarul0 sorry that my changes caused a disruption in your extension experience. I added all ru layouts only because I was thinking that the use cases are limited to these layouts only. Obviously, I was wrong, so I would graldly extend the Cyrillic layout list to all Ukranian keyboards and promote in the future to extend that list instead of forking the extension

Additionally, please let me know @yarul0 if you would like to adjust the layout conversion map if that doesn't work in all cases

@yarul0
Copy link
Author

yarul0 commented Feb 4, 2025 via email

@red-avtovo red-avtovo mentioned this pull request Feb 4, 2025
5 tasks
@red-avtovo
Copy link
Contributor

@yarul0 please take a look at my PR and let me know if anything is missing

@yarul0
Copy link
Author

yarul0 commented Feb 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants