-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Successfully builds in windows using msys and Enthought Python #5
base: master
Are you sure you want to change the base?
Conversation
…SYS. Added spicemodule_custom.c and spicemodule_custom.h
thanks! be careful with the 64-bit results though. I have a bug registered (not many details alas) where I met significantly different results on my Mac between the 32-bit and the 64-bit version. It still might be that i messed something up while testing it, but I would encourage you do to some scripted comparisons between a 32-bit and a 64-bit version to see if everything matches. |
Thanks for the warning. ------Original Message------ thanks! be careful with the 64-bit results though. I have a bug registered (not many details alas) where I met significantly different results on my Mac between the 32-bit and the 64-bit version. It still might be that i messed something up while testing it, but I would encourage you do to some scripted comparisons between a 32-bit and a 64-bit version to see if everything matches. Reply to this email directly or view it on GitHub: Sent via BlackBerry by AT&T (please excuse brevity and typeos) |
@Carl4 thanks for the changes! Have you, by chance, confirmed this still builds fine on a linux system? |
Not yet. ------Original Message------ @Carl4 thanks for the changes! Have you, by chance, confirmed this still builds fine on a linux system? Reply to this email directly or view it on GitHub: Sent via BlackBerry by AT&T (please excuse brevity and typeos) |
libraries = ['cspice'], | ||
include_dirs=[os.path.join(CSPICE_SRC, 'include'),], | ||
library_dirs=[os.path.join(CSPICE_SRC, 'lib'),], | ||
define_macros=[('MSDOS', None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line probably breaks Linux compatibility. Need an If statement.
…llocation from working properly. Now compiles correctly in Linux and Winows.
Conflicts: spicemodule_custom.c
@Carl4, apologies for totally sleeping on this one. @michaelaye, can you confirm this branch works for you on *NIX. Thanks! |
rca,
I have posted some changes that let the code successfully build in Windows x64 using msys compiler that comes with the Enthought Python Distribution. I've also started implementing "custom functions" in spicemodule_custom.c for those that are on the exclude list but need to be implemented. I haven't tested my changes in Linux.