Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midparental-height-validation #238

Merged
merged 9 commits into from
Dec 31, 2024
Merged

midparental-height-validation #238

merged 9 commits into from
Dec 31, 2024

Conversation

eatyourpeas
Copy link
Member

Overview

Fixes midparental height validation
Introduces SD validation cut-offs to maternal and paternal heights. applies to CDC and UK-WHO

closes #237

@eatyourpeas
Copy link
Member Author

question largely for @mbarton
The response object error has changed a little with this PR:

{
    "detail": [
        {
            "loc": [
                "body"
            ],
            "msg": "Error: The paternal height is < -6 SD. Please check the accuracy of the paternal height and try again.",
            "type": "value_error",
            "input": "height_paternal"
        },
        {
            "loc": [
                "body"
            ],
            "msg": "Error: The maternal height is < -6 SD. Please check the accuracy of the maternal height and try again.",
            "type": "value_error",
            "input": "height_maternal"
        }
    ]
}

Here the detail element is now a list rather than a single object, in case both parameters (height_paternal and height_maternal) have errors. As goes the @mbarton spidey sense - is this a minor version change or a patch (here it is just a patch).

@eatyourpeas eatyourpeas self-assigned this Dec 31, 2024
@eatyourpeas
Copy link
Member Author

v4.3.0 included WHO reference. This adds mid-parental-height validation closes #237

@eatyourpeas eatyourpeas merged commit d69450e into live Dec 31, 2024
4 checks passed
@eatyourpeas eatyourpeas deleted the eatyourpeas/issue237 branch December 31, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

midparental height has no validation
1 participant