Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EasyConnect app #65

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tuckerpo-cl
Copy link

For publishing EasyConnect data relevant to third party applications (such as publishing frames containing CCE IEs for EasyMesh DPP). This is a replacement PR for #60
See comments on that PR for previous discussion


Unsure which Onewifi path would be OK to add for publishing frames containing CCE IEs in wifi_base.h...

Perhaps something like #define WIFI_ACCESSPOINT_CCE_IND "Device.WiFi.AccessPoint.{i}.CCEInd" ?

@tuckerpo-cl tuckerpo-cl marked this pull request as draft December 24, 2024 16:38
@tuckerpo-cl
Copy link
Author

tuckerpo-cl commented Dec 24, 2024

@vivianecordeiro-sky We took your advice and moved CCE IE parsing and publishing into its own Onewifi app -- how does this look?

@soumyasmunshi Any thoughts on a bus path to publish to?

@vivianecordeiro-sky
Copy link
Contributor

@tuckerpo-cl, the app code looks great.

For publishing EasyConnect data relevant to third party applications
(such as publishing frames containing CCE IEs for EasyMesh DPP)

Signed-off-by: Tucker Polomik <[email protected]>
@tuckerpo-cl
Copy link
Author

@vivianecordeiro-sky Thanks.

I'm unsure how the ONEWIFI_*_APP_SUPPORT define(s) are meant to propagate to wifi_apps.c -- adding it to the makefile and running export ONEWIFI_EASYCONNECT_APP_SUPPORT=1 && make -f build/linux/makefile all correctly pulled in and built onewifi/source/apps/easyconnect/*.c, but I still needed to manually add #define ONEWIFI_EASYCONNECT_APP_SUPPORT 1 at the top of wifi_apps.c to build the correct extern'd functions. Is there any additional build file which needs this define check?

Additionally, is there a good Onewifi bus path to publish to that can be defined in wifi_base.h? Once that's determined & tested, this can be considered completed and ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants