Skip to content

Commit

Permalink
Marking that all MemoryObserverImpl method are an override of IMemory…
Browse files Browse the repository at this point in the history 
… ones

[109/145] Building CXX object tests/TestUtility/CMakeFiles/ThunderTestUtility.dir/TestUtility.cpp.o
FAILED: tests/TestUtility/CMakeFiles/ThunderTestUtility.dir/TestUtility.cpp.o 
/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderTestUtility_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -g -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -O0 -g -MD -MT tests/TestUtility/CMakeFiles/ThunderTestUtility.dir/TestUtility.cpp.o -MF tests/TestUtility/CMakeFiles/ThunderTestUtility.dir/TestUtility.cpp.o.d -o tests/TestUtility/CMakeFiles/ThunderTestUtility.dir/TestUtility.cpp.o -c /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp:40:30: error: 'Resident' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            virtual uint64_t Resident() const { return _main.Resident(); }
                             ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/interfaces/IMemory.h:35:26: note: overridden virtual function is here
        virtual uint64_t Resident() const = 0;
                         ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp:42:30: error: 'Allocated' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            virtual uint64_t Allocated() const { return _main.Allocated(); }
                             ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/interfaces/IMemory.h:36:26: note: overridden virtual function is here
        virtual uint64_t Allocated() const = 0;
                         ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp:44:30: error: 'Shared' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            virtual uint64_t Shared() const { return _main.Shared(); }
                             ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/interfaces/IMemory.h:37:26: note: overridden virtual function is here
        virtual uint64_t Shared() const = 0;
                         ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp:46:29: error: 'Processes' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            virtual uint8_t Processes() const { return (IsOperational() ? 1 : 0); }
                            ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/interfaces/IMemory.h:38:25: note: overridden virtual function is here
        virtual uint8_t Processes() const = 0;
                        ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/tests/TestUtility/TestUtility.cpp:48:26: error: 'IsOperational' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            virtual bool IsOperational() const { return _main.IsActive(); }
                         ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Debug/install/usr/include/Thunder/interfaces/IMemory.h:39:22: note: overridden virtual function is here
        virtual bool IsOperational() const = 0;
                     ^
5 errors generated.
  • Loading branch information
@VeithMetro
VeithMetro authored Nov 8, 2024
1 parent 3ac162b commit 152c53e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/TestUtility/TestUtility.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ namespace TestUtility {
}
~MemoryObserverImpl() = default;
public:
virtual uint64_t Resident() const { return _main.Resident(); }
virtual uint64_t Resident() const override { return _main.Resident(); }

virtual uint64_t Allocated() const { return _main.Allocated(); }
virtual uint64_t Allocated() const override { return _main.Allocated(); }

virtual uint64_t Shared() const { return _main.Shared(); }
virtual uint64_t Shared() const override { return _main.Shared(); }

virtual uint8_t Processes() const { return (IsOperational() ? 1 : 0); }
virtual uint8_t Processes() const override { return (IsOperational() ? 1 : 0); }

virtual bool IsOperational() const { return _main.IsActive(); }
virtual bool IsOperational() const override { return _main.IsActive(); }

BEGIN_INTERFACE_MAP(MemoryObserverImpl)
INTERFACE_ENTRY(Exchange::IMemory)
Expand Down

0 comments on commit 152c53e

Please sign in to comment.