Bring Attach and Detach from PluginHost::JSONRPC into OutOfProcessPlu…

…gin class

 [85/145] Building CXX object examples/OutOfProcessPlugin/CMakeFiles/ThunderOutOfProcessPlugin.dir/OutOfProcessPlugin.cpp.o
FAILED: examples/OutOfProcessPlugin/CMakeFiles/ThunderOutOfProcessPlugin.dir/OutOfProcessPlugin.cpp.o 
/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderOutOfProcessPlugin_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Release/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Release/install/usr/include -isystem /Users/runner/work/ThunderNanoServices/ThunderNanoServices/Release/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -O3 -DNDEBUG -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT examples/OutOfProcessPlugin/CMakeFiles/ThunderOutOfProcessPlugin.dir/OutOfProcessPlugin.cpp.o -MF examples/OutOfProcessPlugin/CMakeFiles/ThunderOutOfProcessPlugin.dir/OutOfProcessPlugin.cpp.o.d -o examples/OutOfProcessPlugin/CMakeFiles/ThunderOutOfProcessPlugin.dir/OutOfProcessPlugin.cpp.o -c /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/examples/OutOfProcessPlugin/OutOfProcessPlugin.cpp
In file included from /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/examples/OutOfProcessPlugin/OutOfProcessPlugin.cpp:20:
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/examples/OutOfProcessPlugin/OutOfProcessPlugin.h:216:14: error: 'Thunder::Plugin::OutOfProcessPlugin::Attach' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
        bool Attach(PluginHost::Channel& channel) override;
             ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Release/install/usr/include/Thunder/plugins/JSONRPC.h:740:23: note: hidden overloaded virtual function 'Thunder::PluginHost::JSONRPC::Attach' declared here: different number of parameters (2 vs 1)
        Core::hresult Attach(IShell::IConnectionServer::INotification*& sink /* @out */, IShell* service) override
                      ^
In file included from /Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/examples/OutOfProcessPlugin/OutOfProcessPlugin.cpp:20:
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/ThunderNanoServices/examples/OutOfProcessPlugin/OutOfProcessPlugin.h:217:14: error: 'Thunder::Plugin::OutOfProcessPlugin::Detach' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
        void Detach(PluginHost::Channel& channel) override;
             ^
/Users/runner/work/ThunderNanoServices/ThunderNanoServices/Release/install/usr/include/Thunder/plugins/JSONRPC.h:758:23: note: hidden overloaded virtual function 'Thunder::PluginHost::JSONRPC::Detach' declared here: type mismatch at 1st parameter ('IShell::IConnectionServer::INotification *&' vs 'PluginHost::Channel &')
        Core::hresult Detach(IShell::IConnectionServer::INotification*& sink /* @out */) override
                      ^
2 errors generated.

examples/OutOfProcessPlugin/OutOfProcessPlugin.h

@@ -189,6 +189,9 @@ POP_WARNING()
         END_INTERFACE_MAP
 
     public:
+        using PluginHost::JSONRPC::Attach;
+        using PluginHost::JSONRPC::Detach;
+
         //  IPlugin methods
         // -------------------------------------------------------------------------------------------------------