feat: standardize on one package manager #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Hoover <[email protected]>
brent-hoover
force-pushed
the
remove-yarn-dependency
branch
from
d62110a to
805292c
Compare
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
delagroove
approved these changes
Dec 20, 2021
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
Signed-off-by: Brent Hoover <[email protected]>
|
Superceeded by #813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #None
Impact: minor
Type: refactor
Issue
There is no reason to use more than one type of package manager across the project. We use npm in both api and admin so let's use it here, that's one less thing people need to install to get started.
Solution
Remove the references to yarn from the project
Breaking changes
As far as I know this should not break anything. You can still use yarn and the development-platform still uses yarn (for now)
Testing
Everything should work as before