version bump

readymade-ui · Jun 1, 2020 · dae9a93 · dae9a93
1 parent eff184a
commit dae9a93
Show file tree

Hide file tree

Showing 7 changed files with 42 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "readymade",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "JavaScript microlibrary for developing Web Components with Decorators",
   "main": "index.js",
   "scripts": {

diff --git a/packages/@readymade/core/CHANGELOG.md b/packages/@readymade/core/CHANGELOG.md
@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 1.1.1
+
+- FIX issue that caused array values to not correctly update in some use cases
+- ADD check for `no-attr` attribute on Elements to forego expensive change detection on attributes where not applicable
+
+
 ## 1.1.0
 
 ### BREAKING CHANGES

diff --git a/packages/@readymade/core/bundles/core.js b/packages/@readymade/core/bundles/core.js
@@ -161,9 +161,19 @@ class NodeTree {
         }
     }
     changeNode(node, key, value) {
+        const bracketStartRegex = new RegExp(`\\[`, 'gi');
+        const bracketEndRegex = new RegExp('\\]', 'gi');
+        key = key.replace(bracketStartRegex, `\\[`);
+        key = key.replace(bracketEndRegex, `\\]`);
         const regex = new RegExp(`\{\{(\s*)(${key})(\s*)\}\}`, 'gi');
         const attrId = this.getElementByAttribute(node)[0].nodeName || this.getElementByAttribute(node)[0].name;
         const protoNode = this.$flatMap[attrId].node;
+        if (protoNode.textContent.match(regex)) {
+            node.textContent = protoNode.textContent.replace(regex, value);
+        }
+        if (protoNode.hasAttribute('no-attr')) {
+            return;
+        }
         let attr;
         for (const attribute of protoNode.attributes) {
             attr = attribute.nodeName || attribute.name;
@@ -193,15 +203,17 @@ class NodeTree {
                 node.removeAttribute(check);
             }
         }
-        if (protoNode.textContent.match(regex)) {
-            node.textContent = protoNode.textContent.replace(regex, value);
-        }
     }
     updateNode(node, key, value) {
         if (this.getElementByAttribute(node).length === 0) {
             return;
         }
-        if (isObject(value)) {
+        if (Array.isArray(value)) {
+            for (let index = 0; index < value.length; index++) {
+                this.changeNode(node, `${key}[${index}]`, value[index]);
+            }
+        }
+        else if (isObject(value)) {
             for (const prop in value) {
                 if (value.hasOwnProperty(prop)) {
                     this.changeNode(node, `${key}.${prop}`, value[prop]);

diff --git a/packages/@readymade/core/bundles/core.min.js b/packages/@readymade/core/bundles/core.min.js
diff --git a/packages/@readymade/core/fesm2015/core.js b/packages/@readymade/core/fesm2015/core.js
@@ -157,9 +157,19 @@ class NodeTree {
         }
     }
     changeNode(node, key, value) {
+        const bracketStartRegex = new RegExp(`\\[`, 'gi');
+        const bracketEndRegex = new RegExp('\\]', 'gi');
+        key = key.replace(bracketStartRegex, `\\[`);
+        key = key.replace(bracketEndRegex, `\\]`);
         const regex = new RegExp(`\{\{(\s*)(${key})(\s*)\}\}`, 'gi');
         const attrId = this.getElementByAttribute(node)[0].nodeName || this.getElementByAttribute(node)[0].name;
         const protoNode = this.$flatMap[attrId].node;
+        if (protoNode.textContent.match(regex)) {
+            node.textContent = protoNode.textContent.replace(regex, value);
+        }
+        if (protoNode.hasAttribute('no-attr')) {
+            return;
+        }
         let attr;
         for (const attribute of protoNode.attributes) {
             attr = attribute.nodeName || attribute.name;
@@ -189,15 +199,17 @@ class NodeTree {
                 node.removeAttribute(check);
             }
         }
-        if (protoNode.textContent.match(regex)) {
-            node.textContent = protoNode.textContent.replace(regex, value);
-        }
     }
     updateNode(node, key, value) {
         if (this.getElementByAttribute(node).length === 0) {
             return;
         }
-        if (isObject(value)) {
+        if (Array.isArray(value)) {
+            for (let index = 0; index < value.length; index++) {
+                this.changeNode(node, `${key}[${index}]`, value[index]);
+            }
+        }
+        else if (isObject(value)) {
             for (const prop in value) {
                 if (value.hasOwnProperty(prop)) {
                     this.changeNode(node, `${key}.${prop}`, value[prop]);

diff --git a/packages/@readymade/core/fesm2015/core.min.js b/packages/@readymade/core/fesm2015/core.min.js
diff --git a/packages/@readymade/core/package.json b/packages/@readymade/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@readymade/core",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "JavaScript microlibrary for developing Web Components with TypeScript and Decorators",
   "umd": "./bundles/core.js",
   "main": "./fesm2015/core.js",