Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new opaque_over_existential rule #5915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

@SwiftLintBot
Copy link

SwiftLintBot commented Dec 26, 2024

901 Warnings
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:359:48: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:386:50: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:416:48: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:446:60: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:447:51: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:55:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:58:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:59:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:60:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:125:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:129:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:130:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:131:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:468:70: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:469:69: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:534:26: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:534:77: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:576:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:577:66: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:154:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:155:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:156:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:502:48: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:531:50: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:563:48: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:595:67: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:596:58: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:163:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:275:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:307:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:40:31: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:262:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:263:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:264:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:810:41: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Request.swift:830:46: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1016:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1018:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1032:35: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1033:31: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1040:27: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1040:64: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1136:46: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:114:31: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:116:35: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:117:41: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1344:60: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:178:43: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:180:47: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:181:53: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:280:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:283:33: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:285:37: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:328:72: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:331:66: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:333:71: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:352:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:352:79: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:385:78: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:388:72: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:391:77: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:419:44: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:423:43: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:447:44: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:449:43: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:466:17: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:469:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:485:17: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:488:18: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:490:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:513:73: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:515:63: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:550:39: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:553:34: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:555:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:585:73: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:588:67: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:590:72: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:612:39: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:613:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:647:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:708:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:711:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:733:40: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:734:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:757:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:760:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:783:40: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:784:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:807:38: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:810:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:833:40: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:834:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:873:30: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:877:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:923:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:925:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:969:30: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:973:36: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:214:100: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:67:60: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:73:83: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/URLConvertible+URLRequestConvertible.swift:97:22: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:68:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:71:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:72:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:74:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:151:23: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:155:25: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:156:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:157:20: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:407:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:418:24: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:545:26: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:109:115: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:292:78: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:387:48: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:161:43: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:188:45: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:204:62: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:205:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:234:62: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:235:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:393:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:394:62: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:546:43: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:573:45: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:589:62: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:590:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:618:62: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:619:57: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:246:51: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:271:74: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:272:65: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:298:53: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:439:51: warning: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function parameter (opaque_over_existential)
⚠️ Danger found 901 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 136.
18 Messages
📖 Building this branch resulted in a binary size of 24941.29 KiB vs 24893.21 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.96 s vs 0.95 s on main (1% slower).
📖 Linting Alamofire with this PR took 1.28 s vs 1.28 s on main (0% slower).
📖 Linting Brave with this PR took 8.58 s vs 8.55 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 5.55 s vs 5.56 s on main (0% faster).
📖 Linting Firefox with this PR took 11.18 s vs 11.14 s on main (0% slower).
📖 Linting Kickstarter with this PR took 10.44 s vs 10.42 s on main (0% slower).
📖 Linting Moya with this PR took 0.54 s vs 0.54 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 2.97 s vs 2.96 s on main (0% slower).
📖 Linting Nimble with this PR took 0.83 s vs 0.8 s on main (3% slower).
📖 Linting PocketCasts with this PR took 8.8 s vs 8.81 s on main (0% faster).
📖 Linting Quick with this PR took 0.45 s vs 0.45 s on main (0% slower).
📖 Linting Realm with this PR took 4.55 s vs 4.53 s on main (0% slower).
📖 Linting Sourcery with this PR took 2.35 s vs 2.35 s on main (0% slower).
📖 Linting Swift with this PR took 4.58 s vs 4.56 s on main (0% slower).
📖 Linting VLC with this PR took 1.24 s vs 1.24 s on main (0% slower).
📖 Linting Wire with this PR took 18.54 s vs 18.47 s on main (0% slower).
📖 Linting WordPress with this PR took 11.7 s vs 11.61 s on main (0% slower).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the opaque-over-existential branch 3 times, most recently from 45f3c2d to 14140b4 Compare December 29, 2024 09:45
@SimplyDanny
Copy link
Collaborator Author

This rule leads to false positives when a protocol requires an any argument, e.g.

protocol P {}
protocol R {
  func f(p: any P)
}
struct S: R {
  func f(p: some P) {} // compile error
}

See https://forums.swift.org/t/existential-parameter-type-cannot-be-implemented-with-opaque-type/76895/1.

@SimplyDanny SimplyDanny force-pushed the opaque-over-existential branch 3 times, most recently from cd7caa8 to 5a4877a Compare January 5, 2025 11:26
@SimplyDanny SimplyDanny force-pushed the opaque-over-existential branch from 5a4877a to 99df828 Compare January 8, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants