Teststate enhancement #5920
Open
Teststate enhancement #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
2 tasks
SimplyDanny
requested changes
Dec 29, 2024
CHANGELOG.md
Outdated
|
|
||
| * Teststate enhancement. | ||
| [@aydinomer00](https://github.com/aydinomer00) | ||
| [#5920](https://github.com/realm/SwiftLint/issues/5920) |
There was a problem hiding this comment.
This needs to be a link to the issue describing the enhancement, not the PR implementing it:
Suggested change
| [#5920](https://github.com/realm/SwiftLint/issues/5920) | |
| [#5803](https://github.com/realm/SwiftLint/issues/5803) |
CHANGELOG.md
Outdated
| @@ -7958,3 +7958,9 @@ This release has seen a phenomenal uptake in community contributions! | |||
| ## 0.1.0: Fresh Out Of The Dryer | |||
|
|
|||
| First Version! | |||
|
|
|||
| * Teststate enhancement. | |||
There was a problem hiding this comment.
This entry needs to go right to the top of this file.
| @@ -58,7 +59,7 @@ struct QuickDiscouragedCallRule: OptInRule { | |||
| reason: "Discouraged call inside a '\(name)' block") | |||
| } | |||
| } | |||
|
|
|||
| @@ -47,6 +47,7 @@ struct QuickDiscouragedCallRule: OptInRule { | |||
| guard | |||
| kind == .call, | |||
| let name = dictionary.name, | |||
| name != "@TestState", // İstisna: @TestState için uyarı tetiklenmesin | |||
There was a problem hiding this comment.
Please use English for comments.
I don't think this fix is correct. name will never be @TestState. These are the names of Quick methods, not variables or attributes.
|
|
||
| // Example of incorrect usage (should trigger a warning) | ||
| let triggeringExamples = [ | ||
| "describe(\"foo\") { @TestState var foo = Foo() }" // This should trigger a warning |
There was a problem hiding this comment.
This is not the correct expectation. With the @TestState we don't expect a warning. This is what #5803 is all about.
| import XCTest | ||
| @testable import SwiftLintFramework | ||
|
|
||
| class QuickDiscouragedCallRuleTests: XCTestCase { |
There was a problem hiding this comment.
This new test class is not required. Please use QuickDiscouragedCallRuleExamples instead to add your test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an exception for
@TestStateusage in theQuickDiscouragedCallRule. The rule now excludes@TestStatedeclarations insidedescribeandcontextblocks.Changes Made
QuickDiscouragedCallRuleto add an exception for@TestState.QuickDiscouragedCallRuleTests.CHANGELOG.mdto include details about this enhancement.Current Issues
While the implementation and tests were added successfully, the CI/CD pipeline is failing due to issues in:
IntegrationTestsSwiftLintFrameworkTestsI am currently unable to resolve these failing tests and would appreciate any guidance or suggestions to address them.
Thank you for your support and patience as I work through this contribution!