feat(helm): allow configuring number of threads for Dask workers #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
=======================================
Coverage 31.04% 31.04%
=======================================
Files 26 26
Lines 2500 2500
=======================================
Hits 776 776
Misses 1724 1724 |
tiborsimko
reviewed
Feb 20, 2025
| @@ -196,6 +196,8 @@ spec: | |||
| value: {{ .Values.dask.cluster_default_single_worker_memory | default "2Gi" }} | |||
| - name: REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_MEMORY | |||
| value: {{ .Values.dask.cluster_max_single_worker_memory | default "8Gi" }} | |||
| - name: REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS | |||
| value: !!str {{ .Values.dask.cluster_default_single_worker_threads | default 4 }} | |||
There was a problem hiding this comment.
todo: What about the following news headline:
feat(helm): allow configuring number of threads for Dask workers (#877)
Alputer
added a commit
to Alputer/reana
that referenced
this pull request
Feb 20, 2025
…nahub#877) Following the integration of Dask into REANA and discussions with several REANA users, we identified the need to make the number of threads configurable. This commit introduces two variables to be configured by admins. `REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS` defines the default number of threads per worker when not specified in `reana.yaml` `REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_THREADS` sets the upper limit for user-defined values in `reana.yaml`. Closes reanahub#874
Alputer
force-pushed
the
dask-num-of-threads
branch
from
39be834 to
a9e2a9d
Compare
Alputer
added a commit
to Alputer/reana
that referenced
this pull request
Feb 20, 2025
…nahub#877) Following the integration of Dask into REANA and discussions with several REANA users, we identified the need to make the number of threads configurable. This commit introduces two variables to be configured by admins. `REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS` defines the default number of threads per worker when not specified in `reana.yaml` `REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_THREADS` sets the upper limit for user-defined values in `reana.yaml`. Closes reanahub#874
Alputer
force-pushed
the
dask-num-of-threads
branch
from
a9e2a9d to
744610a
Compare
…nahub#877) Following the integration of Dask into REANA and discussions with several REANA users, we identified the need to make the number of threads configurable. This commit introduces two variables to be configured by admins. `REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADS` defines the default number of threads per worker when not specified in `reana.yaml` `REANA_DASK_CLUSTER_MAX_SINGLE_WORKER_THREADS` sets the upper limit for user-defined values in `reana.yaml`. Closes reanahub#874
Alputer
force-pushed
the
dask-num-of-threads
branch
from
744610a to
3e3dc24
Compare
Alputer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the integration of Dask into REANA and discussions with several REANA users, we identified the need to make the number of threads configurable.
This commit introduces two variables to be configured by admins.
REANA_DASK_CLUSTER_DEFAULT_SINGLE_WORKER_THREADSdefines the default number of threads per worker when not specified inreana.yamlREANA_DASK_CLUSTER_MAX_SINGLE_WORKER_THREADSsets the upper limit for user-defined values inreana.yaml.Closes #874