-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created configuration to set a consumer tag #115
Conversation
The actual consumer tag is completed by appending a random string to preserve uniqueness. If no option is set, then an empty string is passed, which instructs Rabbit to create a consumer tag.
How can I fix the failed tests? I don't think they relate to my edits, and I haven't defined new tests. What should I do? |
What is the purpose of the consumer tag? |
The main purpose of the consumer tag is to identify the connection. It is used to close the connection, and usually it is just generated by the RabbitMQ client. It is possible to set it explicitly, which allows for a better and human-readable identification of the connection in RabbitMQ's admin panel. |
Ok, thanks for the explanation 🙂 Would it never be relevant to start two Rebus instances with the same consumer tag? Or does that not make sense, if it's possible even? |
I haven't tried what happens, but it is an handle that can be used to delete the connection, I would avoid using the exact same consumer tag twice. That's why I included a sort of unique bit, so that the actual consumer tag can be "mostly" human readable while still keeping uniqueness. |
Hello, is there any issue with this PR? Can it go forward? |
Created configuration to set a consumer tag
Sorry for being so slow 😅 It's out as Rebus.RabbitMq 9.3.0 on NuGet.org now! THanks for contributing! 🙂 |
Not a problem at all! Thank you for your time. |
The actual consumer tag is completed by appending a random string to preserve uniqueness. If no option is set, then an empty string is passed, which instructs Rabbit to create a consumer tag.
As discussed in #112.
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.