Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created configuration to set a consumer tag #115

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

savissimo
Copy link
Contributor

The actual consumer tag is completed by appending a random string to preserve uniqueness. If no option is set, then an empty string is passed, which instructs Rabbit to create a consumer tag.

As discussed in #112.


Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

The actual consumer tag is completed by appending a random string to preserve uniqueness.
If no option is set, then an empty string is passed, which instructs Rabbit to create a consumer tag.
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@savissimo
Copy link
Contributor Author

How can I fix the failed tests? I don't think they relate to my edits, and I haven't defined new tests. What should I do?

@mookid8000
Copy link
Member

What is the purpose of the consumer tag?

@mookid8000 mookid8000 self-assigned this Jan 2, 2024
@savissimo
Copy link
Contributor Author

The main purpose of the consumer tag is to identify the connection. It is used to close the connection, and usually it is just generated by the RabbitMQ client. It is possible to set it explicitly, which allows for a better and human-readable identification of the connection in RabbitMQ's admin panel.

@mookid8000
Copy link
Member

Ok, thanks for the explanation 🙂 Would it never be relevant to start two Rebus instances with the same consumer tag? Or does that not make sense, if it's possible even?

@savissimo
Copy link
Contributor Author

savissimo commented Jan 2, 2024

I haven't tried what happens, but it is an handle that can be used to delete the connection, I would avoid using the exact same consumer tag twice. That's why I included a sort of unique bit, so that the actual consumer tag can be "mostly" human readable while still keeping uniqueness.

@savissimo
Copy link
Contributor Author

Hello, is there any issue with this PR? Can it go forward?

@mookid8000 mookid8000 merged commit bcbded3 into rebus-org:master Apr 4, 2024
1 of 2 checks passed
mookid8000 added a commit that referenced this pull request Apr 4, 2024
Created configuration to set a consumer tag
@mookid8000
Copy link
Member

Sorry for being so slow 😅

It's out as Rebus.RabbitMq 9.3.0 on NuGet.org now!

THanks for contributing! 🙂

@savissimo
Copy link
Contributor Author

Not a problem at all! Thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants