incorrect implementation of RabbitMqQueueOptionsBuilder.SetAutoDelete() and ClientConnectionName(string connectionName) to RabbitMqOptionsBuilder to propogate the connection_name property #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s impossible to configure QueueTTL unless autoDelete is ON, and those are completely independent parameters in RMQ.
… connectionName) to RabbitMqOptionsBuilder to propogate the connection_name property. Please note, that this implementation is only relevant for RabbitMQ.Client 5.1.0. When v6 is released, the implementation can be simplified, as shown in the comments.
jarikp
changed the title
|
The second commit could work as temporary fix for Issue 52, until version 6 of RMQ client is released:
|
|
cool! it'll be out in Rebus.RabbitMq 5.1.3 in a few minutes when the ci server finishes munching through the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected error in RabbitMqQueueOptionsBuilder.SetAutoDelete(): it was impossible to configure QueueTTL unless autoDelete is ON, and those are completely independent parameters in RMQ.
The original version cannot be used to setting queue TTL and not enabling autoDelete at the same time. To workaround one had to disable auto-delete through SetAutoDelete() and set queue TTL as AddArgument("x-expires",TTL_MS).
I belive, it will fix issue 55
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.