Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on removing polling from RabbitMQ transport #72

Closed
wants to merge 1 commit into from

Conversation

zlepper
Copy link
Contributor

@zlepper zlepper commented Dec 10, 2020

Hopefully implementation for rebus-org/Rebus#917

I hope by starting this we can start some discussion about how to implement it. Quite a few of the tests are failing now due to timeouts, which I assume is because the Receive method never returns.


Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

@zlepper zlepper marked this pull request as draft December 10, 2020 16:17
@zlepper
Copy link
Contributor Author

zlepper commented Mar 2, 2021

I just cannot make this work as I want, so i'm closing this.

@zlepper zlepper closed this Mar 2, 2021
@mookid8000
Copy link
Member

Sorry to hear about that 😐

@zlepper
Copy link
Contributor Author

zlepper commented Mar 2, 2021

No worries :)

Rebus expects to be able to poll the transport in a lot of places, and suddenly having the transport just hanging until Rebus gets a response doesn't really work out that well. There also seems to be some pushing already, so it's not all bad :) I would just have loved to get rid of the polling entirely, we didn't have to waste cpu cycles waking to check all the time.

@mookid8000
Copy link
Member

(..) waste cpu cycles waking to check all the time

Yeah well, while it does of course consume a little bit of CPU, I don't think it's that bad.... the driver has some kind of blocking + timeout on its polling method, meaning that Rebus does not call it that often when running idle. If would of course have been ideal if messages could be pushed

@zlepper
Copy link
Contributor Author

zlepper commented Mar 2, 2021

The problem is we have to decrease the polling interval to make it not take a while the first time an event comes in, in a while, at least in my experimentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants