Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to make net 5.0 work #75

Closed
wants to merge 32 commits into from
Closed

Conversation

renemadsen
Copy link

  • Adding fixes to make it work with net 5.0.
  • Adding build on github actions for Ubuntu and Windows.
  • Removing support for net4.5.
  • Updating dependencies to latest versions.
  • Updating appveyor.yml to run tests.

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

dependabot-preview bot and others added 20 commits January 29, 2021 04:24
Bumps [microsoft.net.test.sdk](https://github.com/microsoft/vstest) from 16.5.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.5.0...v16.8.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>
…test.sdk-16.8.3

Bump microsoft.net.test.sdk from 16.5.0 to 16.8.3
Bumps [nunit](https://github.com/nunit/nunit) from 3.12.0 to 3.13.0.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md)
- [Commits](nunit/nunit@v3.12...v3.13)

Signed-off-by: dependabot-preview[bot] <[email protected]>
…ter-3.17.0

Bump NUnit3TestAdapter from 3.16.1 to 3.17.0
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ renemadsen
❌ dependabot-preview[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mookid8000
Copy link
Member

Hi again @renemadsen , I really appreciate this! But is there any chance you could squash your commits? I'd like to avoid incorporating commits from @dependabot-preview because it's not a human... 😁

Btw. I there's a thing I've been wondering about: I see you added .NET Standard 2.0, .NET Standard 2.1, and .NET 5.0 as build targets.

What is the purpose of .NET Standard 2.1 in this case? Wouldn't you say that packages that aren't capable of leveraging .NET Standard 2.1 stuff (Span<T>, IAsyncEnumerable, ...) should target .NET Standard 2.0 (for broadest possible reach) .. and what is the purpose of targeting .NET 5.0 even? If I understand things correctly, using the .NET 5.0 runtime would bring performance improvements about, even when the code running is .NET Standard 2.0... do you know anything about this?

Bumps [microsoft.net.test.sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.8.3...v16.9.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@renemadsen
Copy link
Author

Hi again @renemadsen , I really appreciate this! But is there any chance you could squash your commits? I'd like to avoid incorporating commits from @dependabot-preview because it's not a human...

Yes, I can do that, but do consider using dependabot on your projects, since it makes the life of keeping projects up to date so much easier, when you have a lot of repositories to maintain and it's only updating dependencies.

Btw. I there's a thing I've been wondering about: I see you added .NET Standard 2.0, .NET Standard 2.1, and .NET 5.0 as build targets.

What is the purpose of .NET Standard 2.1 in this case? Wouldn't you say that packages that aren't capable of leveraging .NET Standard 2.1 stuff (Span<T>, IAsyncEnumerable, ...) should target .NET Standard 2.0 (for broadest possible reach) .. and what is the purpose of targeting .NET 5.0 even? If I understand things correctly, using the .NET 5.0 runtime would bring performance improvements about, even when the code running is .NET Standard 2.0... do you know anything about this?

I'll do some testing in that regard, since I actually don't really know.
So probably you are right about setting it to netstandard2.0 would be enough.

@mookid8000 mookid8000 self-assigned this Apr 8, 2021
dependabot-preview bot and others added 2 commits April 29, 2021 16:06
…t.net.test.sdk-16.9.4

Bump microsoft.net.test.sdk from 16.8.3 to 16.9.4
@mookid8000 mookid8000 closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants