In RabbitMqTransport.Receive call QueueDeclarePassive only if declare input queue is true #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated to declare the input queue is true. Added unit test
|
|
|
Excellent, thanks! It's out as Rebus.RabbitMq 7.3.1-b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an environment where the Rabbit server configurations are managed manually and where it is important to maintain the performance KPIs, it has a negative impact when checking the existence of the queue which maintains the state of the channel in running.
This situation is not desired as it impacts the performance of the RabbitMQ server and gives information incorrect on the push status of the messages detected in the server monitoring console.
In this context we need to submit the queue existence check to a configuration parameter. At the moment we propose to activate the check only if you ask the library to create the queue.
Best regards.
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.