Possibly fix system staying dead if RabbitMQ was temporary unavailable #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! It's out as Rebus.RabbitMq 7.3.2-b02 on NuGet.org now 🙂 Could you report back in here how it goes? If it works, then I'll release it as a properly versioned package. |
|
I did already make an internal build and published to our private Nuget package, and that does seem to resolve the issue. :) |
|
OK cool, I'll just go ahead and push it as 7.3.2 now then 🙂 |
|
Rebus.RabbitMq 7.3.2 is on NuGet.org now! (or it will be, when their index is updated.... 😁 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
This does instead cause some null references immediately after, as some of the workers apparently try to access the consumer between it being disposed and set to null. I'm not entirely sure to fix that without causing even more issue. The NullReferenceException issues are also temporary, and the normal retrying will resolve it.Fixed
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.