Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add flag to disable alias requirement #983

Closed
wants to merge 1 commit into from

Conversation

stefanmcshane
Copy link

@stefanmcshane stefanmcshane commented Apr 22, 2023

The requirement for an alias is arbitrary. There are many use cases where an alias is not able to be added to an account, or is pointless to do so. An example where it is a pointless requirement is when creating transient AWS sandbox accounts for development use, which must be destroyed.

The MIT license which this library is offered under, states that the library is offered as-is, with no warranties.

This PR adds a feature flag which can be added to the config.yaml (delete-accounts-without-alias) which skips the checks for an alias when deleting accounts.

For anyone who wishes to use this feature flag for testing, you can install the fork by cloning github.com/stefanmcshane/aws-nuke, checking out disable-alias and running go install

Fixes #971

@jwhitcraft
Copy link

@stefanmcshane can you rebase your branch with main?

@ekristen
Copy link
Contributor

Hi Everyone that 👍 this! This feature has been implemented over on the newly promoted fork of aws-nuke where all active development is taking place. The feature is called Bypass Alias Check and there's full documentation on how it works.

Try it out and if you run into issues, open an issue over on the fork.


Please see a copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke accounts without alias
3 participants