[image] use lowercased filename (#2777)

* bump deps * lowercased filepath * make path lowercased to avoid surprisees
rectorphp · Dec 27, 2024 · 21c940d · 21c940d
1 parent c370fbf
commit 21c940d
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 62 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/resources/views/blog/post.blade.php b/resources/views/blog/post.blade.php
@@ -10,7 +10,7 @@
     <meta property="og:type" content="article"/>
     <meta
         property="og:image"
-        content="{{ action(\App\Controller\Socials\PostThumbnailController::class, ['title' => $post->getClearTitle()]) }}?v=3"
+        content="{{ action(\App\Controller\Socials\PostThumbnailController::class, ['title' => $post->getClearTitleLowercased()]) }}?v=3"
     />
 
     <meta
@@ -22,7 +22,7 @@
     <meta name="twitter:title" content="{{ $post->getClearTitle() }}"/>
     <meta
         name="twitter:image"
-        content="{{ action(\App\Controller\Socials\PostThumbnailController::class, ['title' => $post->getClearTitle()]) }}"
+        content="{{ action(\App\Controller\Socials\PostThumbnailController::class, ['title' => $post->getClearTitleLowercased()]) }}?v=3"
     />
     <meta name="twitter:description" content="{{ $post->getPerex() }}"/>
 

diff --git a/src/Controller/Socials/PostThumbnailController.php b/src/Controller/Socials/PostThumbnailController.php
@@ -23,13 +23,13 @@ public function __construct(
     ) {
     }
 
-    public function __invoke(string $title): BinaryFileResponse
+    public function __invoke(string $lowercasedTitle): BinaryFileResponse
     {
-        $imageFilePath = $this->thumbnailGenerator->resolveImageFilePath($title);
+        $imageFilePath = $this->thumbnailGenerator->resolveImageFilePath($lowercasedTitle);
 
         // on the fly
         if (! file_exists($imageFilePath)) {
-            $this->createImage($title, $imageFilePath);
+            $this->createImage($lowercasedTitle, $imageFilePath);
         }
 
         return response()->file($imageFilePath);
@@ -46,7 +46,7 @@ private function createImage(string $title, string $imageFilePath): void
 
         $greenFont = $this->thumbnailGenerator->createFont(FontFile::INTER, '59a35e', 40);
 
-        $post = $this->postRepository->findByTitle($title);
+        $post = $this->postRepository->findByLowercasedTitle($title);
         if (! $post instanceof Post) {
             return;
         }

diff --git a/src/Entity/Post.php b/src/Entity/Post.php
@@ -42,6 +42,11 @@ public function getClearTitle(): string
         return str_replace('?', '', $clearTitle);
     }
 
+    public function getClearTitleLowercased(): string
+    {
+        return strtolower($this->getClearTitle());
+    }
+
     public function getPerex(): string
     {
         return $this->perex;

diff --git a/src/Repository/PostRepository.php b/src/Repository/PostRepository.php
@@ -36,9 +36,9 @@ public function getPosts(): array
         return $this->posts;
     }
 
-    public function findByTitle(string $title): ?Post
+    public function findByLowercasedTitle(string $lowercasedTitle): ?Post
     {
-        $filter = static fn (Post $post): bool => $post->getTitle() === $title;
+        $filter = static fn (Post $post): bool => strtolower($post->getTitle()) === $lowercasedTitle;
         return ArrayLookupFinder::first($this->posts, $filter);
     }