extract DoctrineClass enum

rectorphp · Aug 15, 2024 · bf7589e · bf7589e
1 parent ea1077c
commit bf7589e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/rules/CodeQuality/Enum/DoctrineClass.php b/rules/CodeQuality/Enum/DoctrineClass.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Doctrine\CodeQuality\Enum;
+
+final readonly class DoctrineClass
+{
+    /**
+     * @var string
+     */
+    public const COLLECTION = 'Doctrine\Common\Collections\Collection';
+}
diff --git a/rules/CodeQuality/SetterCollectionResolver.php b/rules/CodeQuality/SetterCollectionResolver.php
@@ -14,6 +14,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
+use Rector\Doctrine\CodeQuality\Enum\DoctrineClass;
 use Rector\Doctrine\TypeAnalyzer\CollectionTypeFactory;
 use Rector\Doctrine\TypeAnalyzer\CollectionVarTagValueNodeResolver;
 use Rector\NodeManipulator\AssignManipulator;
@@ -24,11 +25,6 @@
 
 final readonly class SetterCollectionResolver
 {
-    /**
-     * @var string
-     */
-    private const COLLECTION_CLASS = 'Doctrine\Common\Collections\Collection';
-
     public function __construct(
         private AssignManipulator $assignManipulator,
         private ReflectionResolver $reflectionResolver,
@@ -98,10 +94,10 @@ public function resolveAssignedGenericCollectionType(Class_ $class, ClassMethod
 
     private function isCollectionType(Type $type): bool
     {
-        if ($type instanceof ShortenedObjectType && $type->getFullyQualifiedName() === self::COLLECTION_CLASS) {
+        if ($type instanceof ShortenedObjectType && $type->getFullyQualifiedName() === DoctrineClass::COLLECTION) {
             return true;
         }
 
-        return $type instanceof ObjectType && $type->getClassName() === self::COLLECTION_CLASS;
+        return $type instanceof ObjectType && $type->getClassName() === DoctrineClass::COLLECTION;
     }
 }
diff --git a/src/NodeManipulator/ToManyRelationPropertyTypeResolver.php b/src/NodeManipulator/ToManyRelationPropertyTypeResolver.php
@@ -13,6 +13,7 @@
 use Rector\BetterPhpDocParser\PhpDoc\StringNode;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Doctrine\CodeQuality\Enum\CollectionMapping;
+use Rector\Doctrine\CodeQuality\Enum\DoctrineClass;
 use Rector\Doctrine\CodeQuality\Enum\EntityMappingKey;
 use Rector\Doctrine\CodeQuality\Enum\OdmMappingKey;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
@@ -23,11 +24,6 @@
 
 final readonly class ToManyRelationPropertyTypeResolver
 {
-    /**
-     * @var string
-     */
-    private const COLLECTION_TYPE = 'Doctrine\Common\Collections\Collection';
-
     public function __construct(
         private PhpDocInfoFactory $phpDocInfoFactory,
         private ShortClassExpander $shortClassExpander,
@@ -90,7 +86,7 @@ private function resolveTypeFromTargetEntity(Expr|string $targetEntity, Property
         }
 
         if (! is_string($targetEntity)) {
-            return new FullyQualifiedObjectType(self::COLLECTION_TYPE);
+            return new FullyQualifiedObjectType(DoctrineClass::COLLECTION);
         }
 
         $entityFullyQualifiedClass = $this->shortClassExpander->resolveFqnTargetEntity($targetEntity, $property);