Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Collection<T> type-hint to Collection<TKey, T> #240

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Update Collection<T> type-hint to Collection<TKey, T> #240

merged 1 commit into from
Dec 21, 2023

Conversation

jszutkowski
Copy link
Contributor

@jszutkowski jszutkowski commented Dec 21, 2023 •
edited
Loading

Doctrine Collection takes two arguments: key type and element type. For TypedPropertyFromToManyRelationTypeRector key type was missing. After changes it should work similarly to ImproveDoctrineCollectionDocTypeInEntityRector

@jszutkowski jszutkowski marked this pull request as ready for review December 21, 2023 14:17
@samsonasik
Copy link
Member

Looking good, thank you @jszutkowski

@samsonasik samsonasik merged commit c7ff3e5 into rectorphp:main Dec 21, 2023
6 checks passed
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jszutkowski @samsonasik @TomasVotruba