[CodeQuality] Skip intersection property var type on ImproveDoctrineCollectionDocTypeInEntityRector #344
Conversation
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
This would only skip the rule, which is fine by me, but note that I also tried to create #343 which would also insert the correct Selectable annotation. |
| /** | ||
| * @var Collection<int, CountryRef>&Selectable | ||
| */ | ||
| #[ORM\OneToMany(mappedBy: 'country', targetEntity: CountryRef::class, cascade: ['persist'])] | ||
| private Collection $countryRefs; |
There was a problem hiding this comment.
While this fixes proposed issue, it doesn't make sense from PHP points of view.
This code should be updated as well:
private Collection $countryRefs;Also, in the case of using matching() in many places, this would be correct:
private ArrayCollection $countryRefs;But this is out of scope of this rule. I'd recommend to create custom rule to use ArrayCollection if possible. This is not a propper fix, as it creates ambiguous difference between PHP and docblock analysis.
There was a problem hiding this comment.
It is not possible to use ArrayCollection as type. Depending on the state of the object, it is either ArrayCollection or PersistentCollection.
Closes #342