Cleanup TypeComparator

rectorphp · Jun 30, 2024 · f997ffd · f997ffd
1 parent e08473e
commit f997ffd
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/src/NodeTypeResolver/TypeComparator/TypeComparator.php b/src/NodeTypeResolver/TypeComparator/TypeComparator.php
@@ -156,20 +156,7 @@ private function areArrayTypeWithSingleObjectChildToParent(Type $firstType, Type
         $firstArrayItemType = $firstType->getItemType();
         $secondArrayItemType = $secondType->getItemType();
 
-        if ($this->isMutualObjectSubtypes($firstArrayItemType, $secondArrayItemType)) {
-            return true;
-        }
-
-        if (! $firstArrayItemType instanceof GenericClassStringType) {
-            return false;
-        }
-
-        if (! $secondArrayItemType instanceof GenericClassStringType) {
-            return false;
-        }
-
-        // @todo resolve later better with template map, @see https://github.com/symplify/symplify/pull/3034/commits/4f6be8b87e52117b1aa1613b9b689ae958a9d6f4
-        return $firstArrayItemType->getGenericType() instanceof ObjectType && $secondArrayItemType->getGenericType() instanceof ObjectType;
+        return $this->isMutualObjectSubtypes($firstArrayItemType, $secondArrayItemType);
     }
 
     private function isMutualObjectSubtypes(Type $firstArrayItemType, Type $secondArrayItemType): bool