Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Printer] Remove ltrim() on BetterStandardPrinter #6427

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 13, 2024

first step to migrate to php-parser 5:

on php-parser 4, ltrim is added on print format preserving:

on php-parser 5, ltrim is removed on print format preserving:

as space before <?php is allowed on no-namespaced code.

so just use parent stmt method.

Next is to remove ltrim() on FileProcessor:

$ltrimOriginalFileContent = ltrim($file->getOriginalFileContent());

when upgraded to php-parser 5.

part of rectorphp/rector#8815 process.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba ready to merge 👍

@TomasVotruba TomasVotruba merged commit 129f93c into main Nov 13, 2024
36 checks passed
@TomasVotruba
Copy link
Member

LGTM 👍

@TomasVotruba TomasVotruba deleted the remove-ltrim branch November 13, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants