feat: add AddNamedArgumentsRector #6678

savinmikhail · 2025-01-18T15:49:53Z

In two words this feature doing this:

- (new DateTimeImmutable())->format('Y-m-d');
+ (new DateTimeImmutable())->format(format: 'Y-m-d');

Also for functions, static methods, constructors

It seems for me and my teammates that code with named arguments less prone to errors and more readable

samsonasik · 2025-01-18T15:55:43Z

rules/CodingStyle/Rector/FuncCall/AddNamedArgumentsRector.php

+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use const PHP_VERSION_ID;
+
+final class AddNamedArgumentsRector extends AbstractRector


make implements Rector\VersionBonding\Contract\MinPhpVersionInterface instead of manual check on refactor.

samsonasik · 2025-01-18T15:57:01Z

rules/CodingStyle/Rector/FuncCall/AddNamedArgumentsRector.php

+        $parameters = $this->getParameters($node);
+        $this->addNamesToArgs($node, $parameters);


add hasChanged flag so can return null on no change

TomasVotruba · 2025-01-18T16:50:04Z

Hi, thanks for the proposal.
While named arguments bring some value in multi-arg calls, it could backfire in using them everywhere.

Maintenance cost with renamed ctor args, renamed classes and then params could go to huge extreme.

Saying that, create this as a custom rule for your project, that fits your team needs 😇

savinmikhail · 2025-01-18T17:02:23Z

Thank you guys for incredibly fast feedback :)

savinmikhail · 2025-01-19T04:46:32Z

For anyone searching it, I made a standalone repo

feat: add AddNamedArgumentsRector

3a7b2f3

samsonasik reviewed Jan 18, 2025

View reviewed changes

TomasVotruba closed this Jan 18, 2025

Provide feedback

		$parameters = $this->getParameters($node);
		$this->addNamesToArgs($node, $parameters);