misc

src/Enum/StaticAccessor.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Enum;
+
+final class StaticAccessor
+{
+    /**
+     * @var string
+     */
+    public const STATIC = 'static';
+
+    /**
+     * @var string
+     */
+    public const SELF = 'self';
+}

src/PhpParser/NodeVisitor/FindClassConstFetchNodeVisitor.php

@@ -15,6 +15,7 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use Rector\SwissKnife\Contract\ClassConstantFetchInterface;
+use Rector\SwissKnife\Enum\StaticAccessor;
 use Rector\SwissKnife\Exception\NotImplementedYetException;
 use Rector\SwissKnife\Exception\ShouldNotHappenException;
 use Rector\SwissKnife\ValueObject\ClassConstantFetch\CurrentClassConstantFetch;
@@ -71,7 +72,8 @@ public function enterNode(Node $node): Node|int|null
         if ($constantName === 'class') {
             return null;
         }
-        if ($className === 'self') {
+
+        if ($className === StaticAccessor::SELF) {
             Assert::isInstanceOf($this->currentClass, Class_::class);
 
             $currentClassName = $this->getClassName();
@@ -90,7 +92,7 @@ public function enterNode(Node $node): Node|int|null
             return $node;
         }
 
-        if ($className === 'static') {
+        if ($className === StaticAccessor::STATIC) {
             Assert::isInstanceOf($this->currentClass, Class_::class);
 
             $currentClassName = $this->getClassName();
@@ -163,7 +165,7 @@ private function isCurrentClassConstant(Class_ $currentClass, string $constantNa
     private function getClassName(): string
     {
         if (! $this->currentClass instanceof Class_) {
-            throw new ShouldNotHappenException();
+            throw new ShouldNotHappenException('Class_ node is missing');
         }
 
         $namespaceName = $this->currentClass->namespacedName;