add test fixture to skip default parameter value #57
Conversation
|
test seems green, are you sure it is not different rule or you're using latest version? |
Let me check. I tried to replicate the example provided here #36 (comment), but probably I misunderstood how to properly create the fixture. |
| final class SkipDefault | ||
| { | ||
| public function dontSetParamValue( | ||
| string $Id |
There was a problem hiding this comment.
There is no default value here, the method call bellow is invalid.
There was a problem hiding this comment.
Thanks, added default value. Don't know if the Github Actions will automatically re-run
| final class SkipDefault | ||
| { | ||
| public function dontSetParamValue( | ||
| string $Id = '' |
There was a problem hiding this comment.
type should be union per issue example
There was a problem hiding this comment.
Honestly I am not undestanding how to create the fixture. The bug reported is here: #36 (comment) and in that case the parameter has only one type (int in that case).
There was a problem hiding this comment.
probaly the second one #36 (comment)
There was a problem hiding this comment.
I am trying to give you a fixture for the issue that I reported, i.e. the fact that a method called without setting the default value is reported as an error.
Creates fixture for #36