Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of FIL Rest Protocol test on triton for Kserve (UI -> API) #2204

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

rpancham
Copy link
Contributor

@rpancham rpancham commented Feb 3, 2025

No description provided.

@@ -346,6 +349,47 @@
... AND
... Run Keyword If "${KSERVE_MODE}"=="RawDeployment" Terminate Process triton-process kill=true

Test fil Model Rest Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Test fil Model Rest Inference Via API (Triton on Kserve)' has too many keywords inside (12/10)
@@ -346,6 +349,47 @@
... AND
... Run Keyword If "${KSERVE_MODE}"=="RawDeployment" Terminate Process triton-process kill=true

Test fil Model Rest Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case
[Documentation] Test the deployment of fil model in Kserve using Triton
[Tags] Tier2 RHOAIENG-16915 RunThisTest

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (123/120)
Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL} namespace=${test_namespace}
... download_in_pvc=${DOWNLOAD_IN_PVC} model_name=${FIL_MODEL_NAME}
... storage_size=100Mi memory_request=100Mi
${requests}= Create Dictionary memory=1Gi

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
@rpancham
Copy link
Contributor Author

rpancham commented Feb 3, 2025

Verified with Jenkins Build 2641

Copy link

sonarqubecloud bot commented Feb 3, 2025

@openshift-ci openshift-ci bot added the lgtm label Feb 3, 2025
@bdattoma bdattoma assigned rpancham and unassigned bdattoma Feb 3, 2025
Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bdattoma, rpancham, tarukumar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarukumar tarukumar merged commit 6e42a0d into red-hat-data-services:master Feb 4, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants