kafkabp: Add NewConsumerWithConfigOverriders #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
fishy
commented
Jan 8, 2024
kafkabp/consumer.go
Outdated
| @@ -113,12 +117,16 @@ type consumer struct { | |||
| // - If GroupID is empty, it creates a consumer that has the whole view of the | |||
| // topic. This implementation of Kafka consumer is suitable for use cases like | |||
| // deliver config/data through Kafka to services. | |||
| func NewConsumer(cfg ConsumerConfig) (Consumer, error) { | |||
| func NewConsumer(cfg ConsumerConfig, opts ...SaramaConfigOverrider) (Consumer, error) { | |||
There was a problem hiding this comment.
@kylelemons technically this is a breaking change, but it should not break users' code in 99% of the cases.
if you want to be strict I can also add a NewConsumerWithOverrider function and keep this one intact.
There was a problem hiding this comment.
Nevermind added NewConsumerWithConfigOverriders instead. I think that's also easier for us to track how many services are using it.
pacejackson
approved these changes
Jan 8, 2024
We occasionally have cases that services need to set some sarama config that's not supported by kafkabp.ConsumerConfig, and there's currently no way for them to do that besides forking kafkabp code locally. Provide this as an escape hatch for easier iteration.
fishy
force-pushed
the
kafkabp-override-config
branch
from
4fc3411 to
304ec54
Compare
fishy
changed the title
kylelemons
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally have cases that services need to set some sarama config
that's not supported by kafkabp.ConsumerConfig, and there's currently no
way for them to do that besides forking kafkabp code locally. Provide
this as an escape hatch for easier iteration.