Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault injection with logs #667

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Fault injection with logs #667

wants to merge 35 commits into from

Conversation

HiramSilvey
Copy link

Closes #

💸 TL;DR

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

HiramSilvey and others added 30 commits November 14, 2024 18:19
@HiramSilvey
Rough draft of idea.
767a3b6 
TODO: Determine how to short-circuit Thrift requests.
TODO: Refactor into a common shared function with func parameters.
@HiramSilvey
Refactored into common library.
89dee2f 
Need to add logging, tests, and potentially special Thrift error logic.
@HiramSilvey
Return universal Thrift errors.
0aff005
@HiramSilvey
Revert to only support Transport errors.
fb9035e
@HiramSilvey
Initial POC test. Needs refactoring still.
c4c7c1c
@HiramSilvey
Refactored and moved heavy testing logic into common test.
ed571bf
@HiramSilvey
WIP HTTP tests.
73cee20 
Need to adjust server name matching either for tests or
permanently. The issue with using server prefix instead of the
<service>.<namespace> paradigm is that care needs to be taken to
ensure the prefix doesn't match too many destinations. Blast radius
can explode in that model.

Prometheus exports and logging are next after that.
@HiramSilvey
Fixed HTTP tests.
f18a4c3
@HiramSilvey
Add logging and refine tests.
43a5c57
@HiramSilvey
Use official rand library and update logging.
ac4e91a
@HiramSilvey
go mod tidy
b2d1003
@HiramSilvey
Fixed shortened address to include port trimming.
99dc665
@HiramSilvey
Remove unused function in test code.
3f63e05
@HiramSilvey
Fix lint errors.
4444f33
@HiramSilvey
Update based on PR review comments.
1c77548
@HiramSilvey
Simplified random int generation.
71114b0
@HiramSilvey
Move faults into internal directory.
4fd7018
@HiramSilvey
Fix style.
291b7bc
@HiramSilvey
Remove unused type struct and fix imports.
b6d720f
@HiramSilvey
Expand testing and fix PR review nits.
a892c01
@HiramSilvey
Fix imports formatting.
3bb8fd0
@HiramSilvey
Fix typo.
66851ea
@HiramSilvey
Strip port and anything after it for non-cluster-local addresses.
e2908ff
@HiramSilvey
Fix tests and update HTTP address to strip port automatically.
2e2882b
@HiramSilvey
Add edge case test.
6f2024e
@HiramSilvey
Update to use a different random integer per feature.
d467f04 
This is described in https://github.com/grpc/proposal/blob/master/A33-Fault-Injection.md#evaluate-possibility-fraction.
@HiramSilvey @pacejackson
Fix typo.
d602696 
Co-authored-by: Andrew Boyle <[email protected]>
@HiramSilvey
Abort delay if request context cancelled.
788b3e4
@HiramSilvey
Update test to be more clear what the effect is.
01cf3f0
@HiramSilvey
Fix printf formatters.
e75e5ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HiramSilvey