thriftbp: Tweak client pool connection reuse logic #668
+6
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
mathyourlife-reddit
and removed request for
a team
No tests done, but the number should be small, and for the majority of the connections that's reused before and will not be reused now, they really should not be reused (reusing before is a bug) See https://issues.apache.org/jira/browse/THRIFT-5845 for more context. |
mathyourlife-reddit
approved these changes
Jan 9, 2025
Only exceptions defined in thrift IDL is safe for reuse (getting them means the roundtrip is done fully and the response is read fully). All other errors have different degree of risks for reusing.
fishy
force-pushed
the
thriftbp-client-pool-reuse-logic
branch
from
1d2aecc to
d41e8bf
Compare
konradreiche
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only exceptions defined in thrift IDL is safe for reuse (getting them means the roundtrip is done fully and the response is read fully). All other errors have different degree of risks for reusing.