Skip to content

Commit

Permalink
Fix editor overflow: replace deprecated clip with hidden (#28)
Browse files Browse the repository at this point in the history
## 💸 TL;DR
- The code editor was pushing the height of the UI beyond the view
height
- `overflow: clip` requires additional parameters to define the clip
margin and has other implications for scrolling
  - See: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#clip

## 📜 Details
[Design Doc](<!-- insert Google Doc link here if applicable -->)

[Jira](<!-- insert Jira link if applicable -->)

<!-- Add additional details required for the PR: breaking changes,
screenshots, external dependency changes -->

## 🧪 Testing Steps / Validation
<!-- add details on how this PR has been tested, include reproductions
and screenshots where applicable -->

## ✅ Checks
<!-- Make sure your pr passes the CI checks and do check the following
fields as needed - -->
- [ ] CI tests (if present) are passing
- [ ] Adheres to code style for repo
- [ ] Contributor License Agreement (CLA) completed if not a Reddit
employee
  • Loading branch information
ObsidianSnoo authored Jul 25, 2024
1 parent 47110cc commit fcbd274
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/elements/play-pen/play-pen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class PlayPen extends LitElement {
column-gap: 16px;
display: flex;
flex-direction: row;
overflow: clip;
overflow: hidden;
padding-right: 16px;
padding-left: 16px;
row-gap: 16px;
Expand Down

0 comments on commit fcbd274

Please sign in to comment.