Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate image upload #14

Merged
merged 7 commits into from
May 10, 2024
Merged

Emulate image upload #14

merged 7 commits into from
May 10, 2024

Conversation

Krakabek
Copy link
Collaborator

@Krakabek Krakabek commented Apr 29, 2024

πŸ’Έ TL;DR

Stubs the image upload behaviour for play

πŸ“œ Details

DX-6261

πŸ§ͺ Testing Steps / Validation

Should support the image upload pen

βœ… Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@Krakabek Krakabek marked this pull request as ready for review May 3, 2024 13:19
@Krakabek Krakabek force-pushed the dx-6261-image-uplpoad branch from ce1a397 to ae69dc7 Compare May 7, 2024 10:00
@Krakabek Krakabek force-pushed the dx-6261-image-uplpoad branch from ae69dc7 to 3fbffe8 Compare May 8, 2024 12:59
@Krakabek Krakabek requested a review from niedzielski May 8, 2024 13:02
src/elements/play-preview.ts Outdated Show resolved Hide resolved
src/elements/play-preview.ts Outdated Show resolved Hide resolved
@Krakabek Krakabek self-assigned this May 10, 2024
@Krakabek Krakabek merged commit 87b66e5 into main May 10, 2024
1 check passed
@Krakabek Krakabek deleted the dx-6261-image-uplpoad branch May 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants