Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UI Request Flag #15

Merged
merged 3 commits into from
May 6, 2024
Merged

Use UI Request Flag #15

merged 3 commits into from
May 6, 2024

Conversation

mwood23
Copy link
Contributor

@mwood23 mwood23 commented May 1, 2024

Closes #

💸 TL;DR

This bumps devvit and adds a flag to enabling ui reuqest to the settings modal.

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

CleanShot.2024-05-01.at.15.30.25.mp4

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@mwood23 mwood23 requested review from gunsch and niedzielski May 1, 2024 20:37
Copy link
Collaborator

@gunsch gunsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

I don't love the name "UI Request", I think it's pretty orthogonal to (my understanding of) what the KMP stuff does, and idk how settled we are on that through the codebase already. Is this the time to question it or are we past that point?

Copy link
Member

@niedzielski niedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

src/elements/play-settings-dialog.ts Show resolved Hide resolved
@mwood23
Copy link
Contributor Author

mwood23 commented May 1, 2024

@gunsch It's not too late to change IMO! This is just what we've been calling it for a few months. I think multithreading is a more apt description potentially. I went with what I saw Android had to be consistent.

# Conflicts:
#	package-lock.json
@mwood23 mwood23 merged commit 2d24117 into main May 6, 2024
1 check passed
@mwood23 mwood23 deleted the ui-request-flag branch May 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants