pass meta to fix remote runtime #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedzielski
approved these changes
May 7, 2024
Comment on lines
70
to
73
| #customPost: CustomPostNiceClient | ||
| #uiEventHandler: UIEventHandlerNiceClient | ||
| #meta: Metadata | ||
| #uploaded: () => Promise<Empty> |
There was a problem hiding this comment.
🔕 I think these can all be marked readonly but not new to this patch 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
Without passing the meta you can't use the remote runtime. I can't test it easily, but it feels right for devenv.
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks