Changes generated hostname for compute-go bundles #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing local development, gRPC calls to `[hostname].localhost:1337` can be processed by compute-go. However, this only works if the `hostname` is one DNS "part", so bundles named e.g. `untitled-1712273914361.local` break this. Changing this to `untitled-1712273914361-local` makes this path possible again.
niedzielski
approved these changes
Apr 5, 2024
src/utils/compute-util.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| // to-do: compute-go doesn't seem to replace old bundles. Generate a unique | |||
| // hostname for each new build. | |||
| export function newHostname(name: string, version: number): string { | |||
| return `${name.toLocaleLowerCase().replace(/[^a-z0-9]/, '') || 'untitled'}-${version}.local` | |||
| return `${name.toLocaleLowerCase().replace(/[^a-z0-9]/, '') || 'untitled'}-${version}-local` | |||
There was a problem hiding this comment.
I was mistakenly under the impression that this hostname had to end in .local for compute. Can you just delete the entire -local? I don't think it's adding any value.
There was a problem hiding this comment.
sounds good! deleted, re-confirmed it still works as expected
drops -local entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
When doing local development, gRPC calls to
[hostname].localhost:1337can be processed by compute-go. However, this only works if thehostnameis one DNS "part", so bundles named e.g.untitled-1712273914361.localbreak this.Changing this to
untitled-1712273914361makes this path possible again, and makes local testing possible without gRPC-web.🧪 Testing Steps / Validation
Validated this in local development. This request doesn't require any metadata to succeed.
✅ Checks