Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workspaces from production clusters #4767

Conversation

sadlerap
Copy link
Contributor

With the decision from upstream Konflux to not pursue a workspaces abstraction, it doesn't make sense to have workspaces deployed to the production clusters. Staging will be removed once all of the dependencies on workspaces that exist there (UI) have been changed to no longer depend on workspaces.

With the decision from upstream Konflux to not pursue a workspaces
abstraction, it doesn't make sense to have workspaces deployed to the
production clusters.  Staging will be removed once all of the
dependencies on workspaces that exist there (UI) have been changed to no
longer depend on workspaces.

Signed-off-by: Andy Sadler <[email protected]>
@hugares
Copy link
Contributor

hugares commented Oct 21, 2024

We are sure that the current UI, both for external cluster(hosted on consoledot) and for internal cluster(hosted in the konflux cluster) do not have any dependency on the workspaces?

@sadlerap
Copy link
Contributor Author

I don't believe so, but it'd be good to get confirmation from the UI team just to be sure.

@hugares
Copy link
Contributor

hugares commented Oct 21, 2024

We are sure that the current UI, both for external cluster(hosted on consoledot) and for internal cluster(hosted in the konflux cluster) do not have any dependency on the workspaces?

@sahil143 Can you confirm?

Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sahil143
Copy link
Contributor

We are sure that the current UI, both for external cluster(hosted on consoledot) and for internal cluster(hosted in the konflux cluster) do not have any dependency on the workspaces?

@sahil143 Can you confirm?

Yes, We do not use the workspaces api.

@hugares
Copy link
Contributor

hugares commented Oct 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3de751f into redhat-appstudio:main Oct 22, 2024
6 checks passed
@sadlerap sadlerap deleted the deprecate-workspaces-production branch October 22, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants