Fix priority class of the proactive scaler pods #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This priority class is meant to be lower that priority class used by the tenant pods. The original change created a default class with priority value of 0 and scaler pods used a class with priority of -1. The problem is all the tenants pods get assigned to sandbox-users-pods priority class which has a value of -3, causing the scaler pods to not be evicted from the node when resource are needed. We are planning to remove sandbox so this sandbox-users-pods priority class will be deleted eventually but in the meantime, set scaler pods to -10. Also rename the 2 priority classes so their name are more meaningful. KFLUXINFRA-889 Signed-off-by: Hugo Ares <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, manish-jangra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a209dc5
into
redhat-appstudio:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This priority class is meant to be lower that priority class used by the tenant pods. The original change created a default class with priority value of 0 and scaler pods used a class with priority of -1.
The problem is all the tenants pods get assigned to sandbox-users-pods priority class which has a value of -3, causing the scaler pods to not be evicted from the node when resource are needed.
We are planning to remove sandbox so this sandbox-users-pods priority class will be deleted eventually but in the meantime, set scaler pods to -10.
Also rename the 2 priority classes so their name are more meaningful.
KFLUXINFRA-889