Fixed pod's cpu & mem resource setters helpers. #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation was overwriting any req/limit that was
previosly set for the other resources. For instance, test cases
doing this didn't work properly:
pod.RedefineWithCPUResources(testPod, "1", "1")
pod.RedefineWithMemoryResources(testPod, "512Mi", "512Mi")
The call to pod.RedefineWithMemoryResources() was zero-ing the cpu
req/limits that was just set before ("1", "1") as it was creating a new
empty container.Resources field (corev1.ResourceRequirements{}).
The new implementations don't overwrite other reqs/limits values, it
justs sets/overwrite the corresponding ones (cpu/mem).
The affected test cases were passing until now because a bug in the cert
suite code in the function AreCPUResourcesWholeUnits() that was wrongly
returning "true" when the cpu reqs/limit were not set. It was fixed
here:
redhat-best-practices-for-k8s/certsuite#1631
|
@sebrandon1 this should fix PR #607 |
sebrandon1
approved these changes
Nov 17, 2023
sebrandon1
merged commit 9b8506e
into
redhat-best-practices-for-k8s:main
3 checks passed
sebrandon1
added a commit
to sebrandon1/cnfcert-tests-verification
that referenced
this pull request
Dec 5, 2023
* origin/main: Switch to 1-to-1 result struct mapping (redhat-best-practices-for-k8s#616) Bump github.com/onsi/ginkgo/v2 from 2.13.1 to 2.13.2 (redhat-best-practices-for-k8s#615) Fix CI badge (redhat-best-practices-for-k8s#614) Bump github.com/operator-framework/api from 0.19.0 to 0.20.0 (redhat-best-practices-for-k8s#613) Bump github.com/golang/glog from 1.1.2 to 1.2.0 (redhat-best-practices-for-k8s#612) Fix pointer (redhat-best-practices-for-k8s#611) Add more pod package unit tests (redhat-best-practices-for-k8s#610) Update istio to v1.20.0 (redhat-best-practices-for-k8s#609) Enable PR checks against test suite (redhat-best-practices-for-k8s#607) Fixed pod's cpu & mem resource setters helpers. (redhat-best-practices-for-k8s#608) Bump k8s.io/apiextensions-apiserver from 0.28.3 to 0.28.4 (redhat-best-practices-for-k8s#605) Adjust SynchronizedAfterSuite (redhat-best-practices-for-k8s#602) Revert "Reduce the number of procs for parallel (redhat-best-practices-for-k8s#595)" (redhat-best-practices-for-k8s#601) Revert "Increase flaky retries from 2 to 3 (redhat-best-practices-for-k8s#575)" (redhat-best-practices-for-k8s#600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation was overwriting any req/limit that was previosly set for the other resources. For instance, test cases doing this didn't work properly:
The call to pod.RedefineWithMemoryResources() was zero-ing the cpu req/limits that was just set before ("1", "1") as it was creating a new empty container.Resources field (corev1.ResourceRequirements{}).
The new implementations don't overwrite other reqs/limits values, they just set/overwrite the corresponding ones (cpu/mem).
The affected test cases were passing until now because a bug in the cert suite code in the function AreCPUResourcesWholeUnits() that was wrongly returning "true" when the cpu reqs/limit were not set. It was fixed here:
redhat-best-practices-for-k8s/certsuite#1631