Various ginkgo_removal fixes #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
remove_err_check
branch
9 times, most recently
from
f6ce39e to
7fbf51f
Compare
|
Test suite changes that relate to this: |
|
I'm still seeing failures when running against OCP directly with intrusive tests turned on. I'll remove the WIP when this is complete. |
edcdavid
approved these changes
Dec 12, 2023
Test AC Add daemonset wait logic
sebrandon1
force-pushed
the
remove_err_check
branch
from
7fbf51f to
86f2445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TNF_LOG_LEVELfrom trace to debug for the logging changes made in the suite in PR#1663By("Create deployment")statements that give more context to what the test is actually doing.isDaemonsetReadylogic. It now mirrors what we do in the test suite repo where we compare the number of nodes (GetNumberOfNodes()) to the number of desired scheduled pods in the daemonset. This makes everything much more stable/happy.Marked WIP until I have gotten through all of the tests.